>-----Original Message----- >From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] >Sent: Monday, May 11, 2015 2:48 PM >To: Sumit.Saxena@xxxxxxxxxxxxx >Cc: linux-scsi@xxxxxxxxxxxxxxx; thenzl@xxxxxxxxxx; >martin.petersen@xxxxxxxxxx; hch@xxxxxxxxxxxxx; >jbottomley@xxxxxxxxxxxxx; kashyap.desai@xxxxxxxxxxxxx >Subject: Re: [PATCH v3 6/18] megaraid_sas : Use Block layer tag support for >internal command indexing > >> @@ -1668,6 +1655,10 @@ static int megasas_slave_configure(struct >scsi_device *sdev) >> blk_queue_rq_timeout(sdev->request_queue, >> MEGASAS_DEFAULT_CMD_TIMEOUT * HZ); >> >> + sdev_printk(KERN_INFO, sdev, "qdepth(%d), tagged(%d), " >> + "scsi_level(%d), cmd_que(%d)\n", sdev->queue_depth, >> + sdev->tagged_supported, sdev->scsi_level, >> + (sdev->inquiry[7] & 2) >> 1); > >This noisy printk a) doesn't belong into this patch, and b) shouldn't be a added >at all. Yes, it's not needed. I will remove this printk. If I resend only this patch, then subsequent patches will be affected and needs to be recreated. If you are Ok, then I can send a patch to remove this printk rebased on top of this series. Please let me know your response. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
