The subject line should be "st: implement tape statistics" to fit the general scheme. On Thu, Apr 23, 2015 at 08:06:50AM +0000, Seymour, Shane M wrote: > Signed-off-by: Shane Seymour <shane.seymour@xxxxxx> > Tested-by: Shane Seymour <shane.seymour@xxxxxx> Tested-by is usually used for other testers, not the patch author. Where is the description of what these staistics do and what you need them for? A patch with just a subject and a signoff is unlikely to get applied. A lot of the code seems to be duplicates of what we do in block layer statistics, I wonder if there is any way to share that code? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html