Re: [PATCH 2/9] dm-mpath, scsi_dh: don't let dm detach device handlers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 30, 2015 at 02:21:54PM -0400, Mike Snitzer wrote:
> > While allowing dm-mpath to attach device handlers is a functionality we need
> > for backwards compatibility reason there is no reason to reference count
> > them and detach them if dm-mpath stops using the device for some reason.
> > 
> > If the device handler works for the given device it can just stay attached.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Looks good.  But, unless I'm missing something, these DM and scsi_dh
> changes can be made in separate patches so that I can carry the DM
> change without needing to touch scsi_dh (SCSI maintainer boundary).

Unfortunately they can't.  E.g. if we remove the detach in dm-mpath
but keep the refcounting in scsi_dh we'll leak references.  Of if we
remove the request_module in dm without adding it to scsi we stop
asking for the module.  So I'll need to collect ACKs from both sides
and find a suitable tree to get this in.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux