On Tue, 2015-04-14 at 14:51 +0300, Gilad Broner wrote:
> From: Lee Susman <lsusman@xxxxxxxxxxxxxx>
>
> Adding debugfs capability for ufshcd.
>
> debugfs attributes introduced in this patch:
> - View driver/controller runtime data
> - Command tag statistics for performance analisis
> - Dump device descriptor info
> - Track recoverable errors statistics during runtime
> - Change UFS power mode during runtime
> entry a string in the format 'GGLLMM' where:
> G - selected gear
> L - number of lanes
> M - power mode
> (1=fast mode, 2=slow mode, 4=fast-auto mode,
> 5=slow-auto mode)
> First letter is for RX, second is for TX.
> - Get/set DME attributes
>
> Signed-off-by: Lee Susman <lsusman@xxxxxxxxxxxxxx>
> Signed-off-by: Dolev Raviv <draviv@xxxxxxxxxxxxxx>
> Signed-off-by: Yaniv Gardi <ygardi@xxxxxxxxxxxxxx>
> Signed-off-by: Raviv Shvili <rshvili@xxxxxxxxxxxxxx>
> Signed-off-by: Gilad Broner <gbroner@xxxxxxxxxxxxxx>
Bloody test your damn changes. That means running them through a config
options permutation when you introduce config dependencies.
This is what happens with CONFIG_DEBUG_FS=n:
drivers/scsi/ufs/ufshcd.c:92:9: warning: ‘struct scsi_cmd’
declared inside parameter list [enabled by default]
struct scsi_cmd *cmd)
^
drivers/scsi/ufs/ufshcd.c:92:9: warning: its scope is only this
definition or declaration, which is probably not what you want
[enabled by default]
That's a typo inside the other branch of the #ifdef ... apparently none
of your reviewers spotted it either.
drivers/scsi/ufs/ufs-debugfs.c: In function
‘ufsdbg_tag_stats_show’:
drivers/scsi/ufs/ufs-debugfs.c:60:18: error: ‘struct ufs_hba’
has no member named ‘ufs_stats’
ufs_stats = &hba->ufs_stats;
^
...
This lot is obvious: ufs-debufs should not be compiled at all if
CONFIG_DEBUG_FS=n
>From now on, I'm not taking your code unless it has an external reviewer
who makes sure I don't keep running across crap like this.
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
