On 04/16/2015 03:49 PM, Don Brace wrote:
> From: Robert Elliott <elliott@xxxxxx>
>
> If try_soft_reset fails to re-allocate irqs, the error exit
> starts with free_irq calls, which generate kernel WARN
> messages since they were already freed a few lines earlier.
>
> Jump to the next exit label to skip the free_irq calls.
>
> Reviewed-by: Scott Teel <scott.teel@xxxxxxxx>
> Reviewed-by: Kevin Barnett <kevin.barnett@xxxxxxxx>
> Signed-off-by: Robert Elliott <elliott@xxxxxx>
> Signed-off-by: Don Brace <don.brace@xxxxxxxx>
> ---
> drivers/scsi/hpsa.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 8aeef06..dc8299c 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -7773,7 +7773,12 @@ reinit_after_soft_reset:
> if (rc) {
> dev_warn(&h->pdev->dev,
> "Failed to request_irq after soft reset.\n");
> - goto clean4;
> + /*
> + * clean4 starts with free_irqs, but that was just
> + * done. Then, request_irqs_failed, so there is
> + * nothing to free. So, goto the next label.
> + */
> + goto clean3;
> }
>
> rc = hpsa_kdump_soft_reset(h);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
