>>>>> "Sagi" == Sagi Grimberg <sagig@xxxxxxxxxxxxxxxxxx> writes: Sagi> I don't think this is sufficient. With this we actually write Sagi> unprotected data for WRITE_SAME (i.e. write data blocks but not Sagi> storing the corresponding PI information). When this data will be Sagi> read back you will see PI errors (you currently don't see those Sagi> because your backend drive contains escape values I assume). Sagi> I'd say the correct fix is to calc PI for the block Indeed! Sagi> and "write_same" it... Well, the ref tag needs to be incremented for each block (for Type 1). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
