On 4/14/2015 11:56 PM, Martin K. Petersen wrote:
The new integrity code did not correctly unregister the profile for SD disks. Call blk_integrity_unregister() when we release a disk. Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> Reported-by: Sagi Grimberg <sagig@xxxxxxxxxxxxxxxxxx> CC: stable@xxxxxxxxxxxxxxx # v3.17+
Has it been there this long? I wander how we didn't step on this sooner...
--- drivers/scsi/sd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 6b78476d04bb..3290a3ed5b31 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3100,6 +3100,7 @@ static void scsi_disk_release(struct device *dev) ida_remove(&sd_index_ida, sdkp->index); spin_unlock(&sd_index_lock); + blk_integrity_unregister(disk); disk->private_data = NULL; put_disk(disk); put_device(&sdkp->device->sdev_gendev);
Always nice to post a trace, go home, and find the fix in the next morning... Thanks Martin! Tested-by: Sagi Grimberg <sagig@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html