I almost accidentally sent this one again. I still think it's correct. regards, dan carpenter On Mon, Jan 19, 2015 at 05:41:12PM +0300, Dan Carpenter wrote: > If device_add() fails then it should return the error code but instead > the current code returns success. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index ebf35cb6..75a0b55 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3019,7 +3019,8 @@ static int sd_probe(struct device *dev) > sdkp->dev.class = &sd_disk_class; > dev_set_name(&sdkp->dev, "%s", dev_name(dev)); > > - if (device_add(&sdkp->dev)) > + error = device_add(&sdkp->dev); > + if (error) > goto out_free_index; > > get_device(dev); > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
