On Mon, Apr 13, 2015 at 07:34:23PM +0530, Varun Prakash wrote: > define struct ulptx_idata in common header file t4_msg.h > to remove duplicate definitions. The Infiniband side of this patch looks OK. Reviewed-By: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> Just some random thoughts on the other patches: - Try and use 'if (IS_ENABLED(CONFIG_XX))' over #ifdef to improve compile test coverage. This would drop a fair number of ifdefs. - Some of the commit message are short, or non existant (ie #4) - Generally, no need for 'static inline' in a .c file, the compiler knows what to do. Regards, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
