Re: [PATCH 02/14] qla2xxx: Fix crash due to wrong casting of reg for ISP27XX.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/09/15 20:59, Himanshu Madhani wrote:
Signed-off-by: Giridhar Malavali <giridhar.malavali@xxxxxxxxxx>
Signed-off-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
---
  drivers/scsi/qla2xxx/qla_tmpl.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
index a8c0c73..7a92f60 100644
--- a/drivers/scsi/qla2xxx/qla_tmpl.c
+++ b/drivers/scsi/qla2xxx/qla_tmpl.c
@@ -190,7 +190,7 @@ static inline void
  qla27xx_write_reg(__iomem struct device_reg_24xx *reg,
  	uint offset, uint32_t data, void *buf)
  {
-	__iomem void *window = reg + offset;
+	__iomem void *window = (void *)reg + offset;

  	if (buf) {
  		WRT_REG_DWORD(window, data);


Hello Himanshu,

The above patch introduces a new sparse warning since an __iomem annotation is missing from the cast. Had you noticed that I had already posted a fix for this crash in January that does not introduce a new sparse warning ? See also http://thread.gmane.org/gmane.linux.scsi/98426.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux