On 04/06/15 17:08, Christoph Hellwig wrote:
On Sun, Apr 05, 2015 at 08:12:16PM +0200, Bart Van Assche wrote:
Move the
functions that are used by both subsystems into <scsi/scsi_lib.h>.
Rename drivers/scsi/scsi_lib.c into scsi_ini_lib.c. This change
will allow to modify the SCSI target code such that the initiator
SCSI header files are no longer included. Note: the SCSI target
driver patch is available for review at
I don't really like renaming the file that has most of the initiator side
SCSI code that way. If we really have to rename it in some way I'd suggest
just merging it into scsi.c as we call forth and back between the two all
the time.
Maybe we can use scsi_common.c/h/.ko to avoid these moves, although I'd
prefer to just duplicate this tiny amount of code.
Hello Christoph,
Sorry but duplicating code is not really something that makes me
enthusiast ... But I will address all your other comments, including
using the names scsi_common.c/.h.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
