Re: [PATCH] be2iscsi: Fix kernel panic when device initialization fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/11/2015 07:15 PM, John Soni Jose wrote:
>  Kernel panic was happening as iscsi_host_remove() was called on
>  a host which was not yet added.
> 
> Signed-off-by: John Soni Jose <sony.john-n@xxxxxxxxxx>
> ---
>  drivers/scsi/be2iscsi/be_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index f319340..1b0b31c 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -5736,9 +5736,9 @@ free_port:
>  hba_free:
>  	if (phba->msix_enabled)
>  		pci_disable_msix(phba->pcidev);
> -	iscsi_host_remove(phba->shost);
>  	pci_dev_put(phba->pcidev);
>  	iscsi_host_free(phba->shost);
> +	pci_set_drvdata(pcidev, NULL);
>  disable_pci:
>  	pci_disable_device(pcidev);
>  	return ret;
> 

Looks ok.

Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux