Hi Hannes, Thank you for reviewing the patch. Please find responses inline. On 02/03/15 7:04 pm, "Hannes Reinecke" <hare@xxxxxxx> wrote: >On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: >> snic_trc.h contains global trace structure definitions for snic driver >> >> snic_trc.c adds tracing functionality to capture various IO events. >> It maintains global trace buffer to maintain recent history of IO >>events. >> It helps to understand the sequence of events prior to particular IO >>event, >> or hung, panic, etc,. >> >> Signed-off-by: Narsimhulu Musini <nmusini@xxxxxxxxx> >> Signed-off-by: Sesidhar Baddela <sebaddel@xxxxxxxxx> > >Hmm. There _is_ a tracing infrastructure in the kernel. >Any particular reason why you insist on creating your own? The tracing infrastructure in kernel is not enabled by default. And requires manual intervention to enable it. Snic tracing is compact, specific to driver and enabled by default to capture most recent events in IO path. Snic trace facility helps in investigating corner issues. > >Cheers, > >Hannes >-- >Dr. Hannes Reinecke zSeries & Storage >hare@xxxxxxx +49 911 74053 688 >SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg >GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton >HRB 21284 (AG Nürnberg) Thanks Narsimhulu > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
