Re: [PATCH 06/21] lpfc: Fix host reset escalation killing all IOs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2015-02-05 at 14:23 -0500, James Smart wrote:
> ---

This one really requires more than a one-line explanation because the
one liner doesn't really describe what you've done.

It looks like the description should be:

Only the SLI rev 4 card has a host reset capability, so only activate it
in the host template for that card.

Which leads me to two questions:

     1. Is the if condition the right way around?  It seems from the
        previous code that SLI rev < 4 do support a host reset handler.
        At the very least, if the if clause is correct, explain how it
        relates to 27b01b8 [SCSI] lpfc 8.3.31: Fixed system crash due to
        not providing SCSI error-handling host reset handler.
     2. Is this only a problem of SLI rev 4, so == is justified, or
        should it be 4 and above?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux