In general this looks fine, but: - why do you need a separate scsi_lun.h? - I'd really prefer to only have the protocol defintion here, not prototypes for helpers like scsi_device_type, int_to_scsilun and scsilun_to_int. The target code should not depend on the initiator for helpers. In the long run we should either duplicate them, or have a library used by the initiator and target. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
