RE: [patch] megaraid_sas: harmless memory corruption in megasas_mgmt_fw_ioctl()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>-----Original Message-----
>From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx]
>Sent: Wednesday, February 25, 2015 6:53 PM
>To: Kashyap Desai
>Cc: Sumit Saxena; Uday Lingala; James E.J. Bottomley;
>megaraidlinux.pdl@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; kernel-
>janitors@xxxxxxxxxxxxxxx
>Subject: [patch] megaraid_sas: harmless memory corruption in
>megasas_mgmt_fw_ioctl()
>
>The intent here was for the "kbuff_arr[i] = NULL;" to be inside the loop
but,
>because the curly braces were missing, it's after the loop.
>This means we corrupt a little memory one step beyond the array.
>Fortunately, we weren't going to use that memory anyway so it's harmless.
>Also we aren't going to use kbuff_arr[] again so we don't need to set it
to
>NULL.
>
>I have deleted that line of code.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 890637f..834bfc0 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -6208,7 +6208,6 @@ megasas_mgmt_fw_ioctl(struct megasas_instance
>*instance,
>
le32_to_cpu(kern_sge32[i].length),
> 					  kbuff_arr[i],
>
>le32_to_cpu(kern_sge32[i].phys_addr));
>-			kbuff_arr[i] = NULL;
> 	}
>
> 	if (instance->ctrl_context && cmd->mpt_pthr_cmd_blocked)

Acked-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxxx>

-Sumit
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux