Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 23 Feb 2015 09:15:15 -0000
"Dov Levenglick" <dovl@xxxxxxxxxxxxxx> wrote:

[ Cut's a 1000 lines of unneeded patch ]

> > +#endif /* if !defined(_TRACE_UFS_H) || defined(TRACE_HEADER_MULTI_READ)
> > */
> > +
> > +/* This part must be outside protection */
> > +#include <trace/define_trace.h>
> > --
> > Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> 
> Reviewed-by: Dov Levenglick <dovl@xxxxxxxxxxxxxx>

Please, when you add a tag, do it just under the change log, not the
bottom of the patch. And cut out most of the text that people can read
your email on a single page.

It is extremely annoying to scroll down a 1000 lines to find no
comments and just someone giving their "Reviewed-by" tag.

-- Steve

> 
> QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux