On Mon, Feb 09, 2015 at 06:01:39AM +0000, Seymour, Shane M wrote: > Hi All, > > Please find attached v3 of the patch. It implements the changes requested by Greg. The statistics files aren't in a separate directory any more they're implemented directly as device attributes unless someone has objections to them being in a place like /sys/class/scsi_tape/*/. Why not keep them in a subdir, like before? You can still do that with a sysfs attribute group, just make a new one and add it to the existing list of groups for the tape device. Makes things a bit more "simple" for userspace, they can just iterate over all of the files in the directory, instead of having to only open some of them. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html