On Wednesday 04 February 2015 08:42:03 Tina Ruchandani wrote: > struct timeval will have its tv_sec field overflow on 32-bit systems > in year 2038 and beyond. This patch removes the usage of struct timeval > and instead uses ktime_get_real_seconds() which returns 64-bit wall-clock > seconds. > > Signed-off-by: Tina Ruchandani <ruchandani.tina@xxxxxxxxx> > The patch is correct, but you can do it better by removing the bfa_get_log_time() function completely and changing the four callers to call ktime_get_real_seconds() directly. The subject line could be improved too: you don't remember all uses of timeval in this patch, but only one of them. When you do the first change, a good subject line would be: [SCSI] bfa: replace bfa_get_log_time with ktime_get_real_seconds Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html