On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote: > There is some confusion in the SCSI core and in SCSI LLDs around the > meaning of sc_data_direction and whether or not this member can have the > value DMA_BIDIRECTIONAL. Clear up this confusion. The patches in this > series are: I wonder if we should change the code to set DMA_BIDIRECTIONAL for bidi commands. That seems a lot more logical than the current version. Also I don't think all the debug checks for bidi commands that you change should stay at all - driver need to set the QUEUE_FLAG_BIDI to ever see a bidi command. It would also nice to add a host template flag for bidi support instead of having to poke into the block layer request_queue while we're at it. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html