On Wed, 2014-12-17 at 15:51 +0000, Praveen Madhavan wrote: > Hi Christoph, > csiostor is chelsio full offload FCoE physical function driver. I > would like to reuse common hardware interface functions defined in > t4_hw.c of chelsio networking driver(cxgb4). Below is makefile change > that creates softlink to t4_hw.c and builds the same. Is this change > is acceptable? Please suggest if there is any better way of doing > this. The usual way to do this is to make the common hardware function a base module and make all drivers that use it depend on it. Like iwldvm -> iwlwifi -> mac80211 etc. We really wouldn't want to do the link and build because that will create two identical binary copies of the interface (one in SCSI and one in net) which is a waste of text space. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html