Re: [PATCH 1/4] be2iscsi : Fix the retry count for boot targets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/14, 8:33 PM, John Soni Jose wrote:
+#define GET_BOOT_RETRIES	45
+#define GET_BOOT_TO		20
  /**

Does beiscsi_get_boot_info() succeed when the fw is able to log into the target (go into iscsi full feature phase) or just able to reach it (ICMP ping the port or something like that)? It was not clear why the above values were selected. Was it meant to detect when the target could be down for extended periods due to something like maintenance or a reboot, or is just handling some shorter settle period where the link is up but the fw could not reach the target port due to needing to do some other network setup.

Also, I think you want to add some sort of BEISCSI or at least BE prefix to the names to avoid collisions since they are pretty generic.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux