Martin K. Petersen wrote on 12/11/2014 07:12 PM: >>>>>> "Vlad" == Vladislav Bolkhovitin <vst@xxxxxxxx> writes: > Vlad> We are currently developing a SCSI target system with T10-PI. We > Vlad> are using block integrity interface and found a problem that this > Vlad> interface fundamentally can not pass Oracle T10-PI certification > Vlad> tests. Those tests require to receive on the initiator side > Vlad> information about which particular tag failed the target checks, > Vlad> but the block integrity interface does not preserve this > Vlad> information, hence the target can not deliver it to the initiator > Vlad> => certification failure. The storage provides the right sense, > Vlad> but then in scsi_io_completion() it is dropped and replaced by a > Vlad> single EILSEQ. > > Vlad> What would be the best way to fix that? By making a patch > Vlad> introducing new -EXXXXXX error codes for the PI errors? > > I posted such a patch a while back. We use that in our qualification > tooling to ensure that the right things are reported when a PI error is > injected at various places in the stack. Thanks, this is exactly what is needed. Reviewed-by: Vladislav Bolkhovitin <vst@xxxxxxxx> > One thing that needs to be done is to make returning these new errors to > userland conditional on !BIP_BLOCK_INTEGRITY. I'll put that on my list. Ever without it this patch is quite valuable. Vlad -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html