Thanks for the review. V6 has been submitted to address this. -----Original Message----- From: Sergei Shtylyov [mailto:sergei.shtylyov@xxxxxxxxxxxxxxxxxx] Sent: Wednesday, December 10, 2014 6:09 AM To: Karen Xie; linux-scsi@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx Cc: Hariprasad S; Anish Bhatt; hch@xxxxxxxxxxxxx; James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; michaelc@xxxxxxxxxxx; davem@xxxxxxxxxxxxx Subject: Re: [PATCH net v5 2/7] cxgb4i: fix credit check for tx_data_wr Hello. On 12/10/2014 4:43 AM, Karen Xie wrote: > [PATCH net v5 2/7] cxgb4i: fix credit check for tx_data_wr > From: Karen Xie <kxie@xxxxxxxxxxx> > make sure any tx credit related checking is done before adding the wr header. > Signed-off-by: Karen Xie <kxie@xxxxxxxxxxx> > --- > drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > index f119a67..56dbd25 100644 > --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c > @@ -547,15 +547,16 @@ static inline void make_tx_data_wr(struct > cxgbi_sock *csk, struct sk_buff *skb, [...] > req->op_to_immdlen = htonl(FW_WR_OP(FW_OFLD_TX_DATA_WR) | > - FW_WR_COMPL(1) | > - FW_WR_IMMDLEN(dlen)); > + FW_WR_COMPL(1) | > + FW_WR_IMMDLEN(dlen)); > req->flowid_len16 = htonl(FW_WR_FLOWID(csk->tid) | > - FW_WR_LEN16(credits)); > + FW_WR_LEN16(credits)); The above looks like unrelated cleanup, worth putting in a separate net-next patch... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
