This patch seems to be good. Please consider this patch as Acked-by: "Sreekanth Reddy" <Sreekanth.Reddy@xxxxxxxxxxxxx> Regards, Sreekanth On Thu, Dec 4, 2014 at 4:27 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > The "issue_reset" can be used uninitialized. It should be set to false > at the start. > > Also I cleaned up the types a little by using bool. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > v2: style fix. use true/false instead of 1/0. > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index 1560115..b9c2739 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -3419,7 +3419,7 @@ mpt3sas_base_sas_iounit_control(struct MPT3SAS_ADAPTER *ioc, > u16 smid; > u32 ioc_state; > unsigned long timeleft; > - u8 issue_reset; > + bool issue_reset = false; > int rc; > void *request; > u16 wait_state_count; > @@ -3483,7 +3483,7 @@ mpt3sas_base_sas_iounit_control(struct MPT3SAS_ADAPTER *ioc, > _debug_dump_mf(mpi_request, > sizeof(Mpi2SasIoUnitControlRequest_t)/4); > if (!(ioc->base_cmds.status & MPT3_CMD_RESET)) > - issue_reset = 1; > + issue_reset = true; > goto issue_host_reset; > } > if (ioc->base_cmds.status & MPT3_CMD_REPLY_VALID) > @@ -3523,7 +3523,7 @@ mpt3sas_base_scsi_enclosure_processor(struct MPT3SAS_ADAPTER *ioc, > u16 smid; > u32 ioc_state; > unsigned long timeleft; > - u8 issue_reset; > + bool issue_reset = false; > int rc; > void *request; > u16 wait_state_count; > @@ -3581,7 +3581,7 @@ mpt3sas_base_scsi_enclosure_processor(struct MPT3SAS_ADAPTER *ioc, > _debug_dump_mf(mpi_request, > sizeof(Mpi2SepRequest_t)/4); > if (!(ioc->base_cmds.status & MPT3_CMD_RESET)) > - issue_reset = 1; > + issue_reset = false; > goto issue_host_reset; > } > if (ioc->base_cmds.status & MPT3_CMD_REPLY_VALID) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
