On Thursday 04 December 2014 08:12:53 Hannes Reinecke wrote: > On 12/03/2014 07:29 PM, Ondrej Zary wrote: > > On Wednesday 03 December 2014 12:44:53 Hannes Reinecke wrote: > >> Hi all, > >> > >> it has been bugged me for ages that the advansys driver always > >> reported a compilation warning about not having been converted > >> to the DMA-API. > >> And even aggressive waiting hasn't made this warning go away. > >> > >> So here's a patchset to update the advansys driver to current > >> standards and use the DMA-API. > >> Tested on ABP940-U2W. > >> > >> As usual, reviews and comments are welcome. > >> > >> Hannes Reinecke (12): > >> advansys: use host_reset > >> advansys: use shared host tag map for command lookup > >> advansys: use DMA-API for mapping sense buffer > >> advansys: Use DMA-API for carrier buffer > >> advansys: Use DMA-API for mapping request blocks > >> advansys: Use dma_pool for sg elements > >> advansys: use 'bool' instead of 'int' > >> advansys: use standard data types > >> advansys: Remove 'TRUE' and 'FALSE' definitions > >> advansys: Remove 'ERR' definition > >> advansys: cleanup function return codes > >> advansys: Update to version 3.5 and remove compilation warning > >> > >> MAINTAINERS | 1 + > >> drivers/scsi/advansys.c | 1073 > >> +++++++++++++++++++++-------------------------- 2 files changed, 469 > >> insertions(+), 605 deletions(-) > > > > Seems to break narrow boards, at least mine ASB-3940UA :( > > > > [ 4.266292] ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 9 > > [ 7.661374] scsi host2: AdvanSys SCSI 3.5: PCI Ultra: IO > > 0xA800-0xA80F, IRQ 0x9 [ 28.840078] scsi 2:0:0:0: SCSI bus reset > > started... > > [ 28.846640] scsi 2:0:0:0: SCSI bus reset error: 0x2, status: 0x0 > > [ 28.846648] scsi 2:0:0:0: Device offlined - not ready after error > > recovery [ 28.846803] scsi 2:0:1:0: ExeScsiQueue() ASC_ERROR, err_code > > 0x2 [ 28.852052] scsi 2:0:1:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.860051] scsi 2:0:1:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.868047] scsi 2:0:1:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.868249] scsi 2:0:2:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.876050] scsi 2:0:2:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.884048] scsi 2:0:2:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.892047] scsi 2:0:2:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.892243] scsi 2:0:3:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.900051] scsi 2:0:3:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.908048] scsi 2:0:3:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.916047] scsi 2:0:3:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.916241] scsi 2:0:4:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.924051] scsi 2:0:4:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.932048] scsi 2:0:4:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.940048] scsi 2:0:4:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.940240] scsi 2:0:5:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.948051] scsi 2:0:5:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.956049] scsi 2:0:5:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.964047] scsi 2:0:5:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.964239] scsi 2:0:6:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.972050] scsi 2:0:6:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.980048] scsi 2:0:6:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 [ > > 28.988050] scsi 2:0:6:0: ExeScsiQueue() ASC_ERROR, err_code 0x2 > > > > Before the patch: > > [ 4.226690] ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 9 > > [ 7.644841] scsi host2: AdvanSys SCSI 3.4: PCI Ultra: IO > > 0xA800-0xA80F, IRQ 0x9 [ 8.072257] scsi 2:0:2:0: Processor HP > > C1790A 3226 PQ: 0 ANSI: 2 [ 8.919128] scsi 2:0:2:0: > > Attached scsi generic sg3 type 3 > > Right. So _this_ was the mysterious command about srb_tag '0' being > reserved. Can you try with this patch? Thanks, it fixes the problem. -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
