Re: [PATCH qla2xxx] Race in handling rport deletion in Qlogic driver during recovery causes panic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Thu, 4 Dec 2014, Christoph Hellwig wrote:

On Tue, Nov 25, 2014 at 09:16:42AM -0500, Laurence Oberman wrote:
When we have an rport disconnect we race during rport deletion and re-connection resulting in a panic.
When we do this, we call fc_remote_port_del() just before we do the calls to re-establish the session with
the FC transport with fc_remote_port_add() and then fc_remote_port_rolechg().

If we remove the call to fc_remote_port_del() before re-establishing the connection this prevents the race.
This patch has resolved this for multiple customers via test kernels.

Suggested by Chad Dupuis, implemented and tested by Laurence Oberman.

Chad, can you review this one?  Or do you plan to send it to me with the
next qla2xxx update?  Note that the 3.19 merge window is about to end.

This looks good. Thanks.

Acked-by: Chad Dupuis <chad.dupuis@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux