On Wed, Dec 03, 2014 at 11:36:20AM +0100, Julia Lawall wrote: > On Wed, 3 Dec 2014, Dan Carpenter wrote: > > > The issue_reset variables were never set to zero. This bug was found > > with static analysis. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c > > index 58e4521..98bd546 100644 > > --- a/drivers/scsi/mpt2sas/mpt2sas_base.c > > +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c > > @@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc, > > u16 smid; > > u32 ioc_state; > > unsigned long timeleft; > > - u8 issue_reset; > > + bool issue_reset = 0; > > Why not false if it is going to be a boolean? > Good point. I'll send a v2 for these tomorrow. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
