> +/*
> + * AMD am53c974 driver.
> + * Copyright (c) 2014 Hannes Reinecke, SUSE Linux GmbH
> + */
Is there anything left from the old driver that should get credit here?
> +#define PCI_ESP_GET_PRIV(esp) ((struct pci_esp_priv *) \
> + pci_get_drvdata((struct pci_dev *) \
> + (esp)->dev))
I think an inline function would be a lot cleaner, especially as that
should avoid all these casts.
> +#ifdef ESP_DMA_DEBUG
> + shost_printk(KERN_INFO, esp->host, "start dma addr[%x] count[%d:%d]\n",
> + addr, esp_count, dma_count);
> +#endif
Can you add a esp_dma_printk or similar instead of all these ifdefs?
> + u8 carryFlag = 1, j = 0x80, bval;
carry_flag.
> + if (pci_request_regions(pdev, DRV_MODULE_NAME)) {
> + if (request_irq(pdev->irq, scsi_esp_intr, IRQF_SHARED,
> + DRV_MODULE_NAME, esp)) {
Please propagate the return values from these two.
Otherwise looks good. Please resend with fixes for these and Dave's
style comment, and I'll apply it.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
