On 11/24/2014 09:54 AM, Christoph Hellwig wrote: >> Why did you not remove the last argument from asd_can_queue() and >> asd_can_dequeue(), too? >> With that patch it's always '1' ... > > Because I wanted to remove the libsas (mis-)feature and avoid to many boad > driver changes. Especially for a unmaintained big driver like aic94xx. > >> This 'while' loop can go, too. > > Same here. Note that this driver never even allowed task collector mode, > so it was already dead code. > Okay. Reviewed-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html