On 11/21/2014 11:26 AM, Christoph Hellwig wrote: > On Fri, Nov 21, 2014 at 10:27:47AM +0100, Hannes Reinecke wrote: >> Hi all, >> >> having found some issues with the current tmscsim driver >> I looked at the code and found is really awkward to clean >> up. >> Seeing that the am53c974 chip is actually based on the >> 'ESP' chip design I've re-implemented it based on the >> common esp_scsi routines. This new driver >> (cunningly named 'am53c974') provides all features >> found on the tmscsim driver, with the goal of obsoleting >> the old tmscsim driver. >> Tested with Tekram DC390 and qemu esp-scsi. > > This looks very nice! > > Three high level comments: > > - please Cc Dave for changes to esp_scsi That's what I thought, too, but 'get_maintainers.pl' doesn't know about him. Maybe we should fix this up ... > - please Cc Guennadi as the tmscsim maintainer > - this probably should deprecated and/or remove the tmscsim driver > That was the general idea. I just thought to be conservative and add a new driver. But yeah, the idea is to sent another patch to remove tmscsim altogether. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
