Re: [PATCH 2/7] scsi: avoid ->change_queue_depth indirection for queue full tracking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 13, 2014 at 07:47:19PM +0000, venkateshs@xxxxxxxxxx wrote:
> On Thu, Nov 13, 2014 at 06:59:01PM +0100, Christoph Hellwig wrote:
> >All drivers use the implementation for ramping the queue up and down, so
> >instead of overloading the change_queue_depth method call the
> >implementation diretly if the driver opts into it by setting the
> >track_queue_depth flag in the host template.
> >
> >Note that a few drivers validated the new queue depth in their
> >change_queue_depth method, but as we never go over the queue depth
> >set during slave_configure or the sysfs file this isn't nessecary
> >and can safely be removed.
> >
> >Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> This patch plus the change to remove the 'tagged' argument to
> scsi_adjust_queue_depth() form a nice cleanup.
> 
> Reviewed-by: Venkatesh Srinivas <venkateshs@xxxxxxxxxx>

Any chance to get a review for the other patches in the series as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux