Re: [PATCH V4 4/5] scsi: Change default value of max_report_luns to 16k-1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +++ b/drivers/scsi/scsi_scan.c
> @@ -105,12 +105,13 @@ MODULE_PARM_DESC(scan, "sync, async or none");
>   * in practice, the maximum number of LUNs suppored by any device
>   * is about 16k.
>   */
> -static unsigned int max_scsi_report_luns = 511;
> +static unsigned int max_scsi_report_luns = 16383;
>  
>  module_param_named(max_report_luns, max_scsi_report_luns, uint, S_IRUGO|S_IWUSR);

What's the point of keepign this parameter?  From looking at ancient
history we initially supported just 128 LUNs by default when Doug added
support for REPORT_LUNS, and we later increased it to 511 when Kurt
enabled REPORT_LUNS support by default.

I can't really see any reason to limit the size except for avoiding
large allocations, and with the two step process we take care of that
easily.

Any reason to keep two responses around in the file instead of a
"goto retry" after updating the length?

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux