Re: [PATCH 3/6] scsi: clean up S/G table freeing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 18, 2014 at 06:14:30PM +0000, Bart Van Assche wrote:
> > -
> > -	memset(&cmd->sdb, 0, sizeof(cmd->sdb));
> > -
> > -	if (scsi_prot_sg_count(cmd))
> > -		scsi_free_sgtable(cmd->prot_sdb, false);
> > -}
> 
> Hello Christoph,
> 
> Since I'm traveling I'm using a laptop with a small screen so I might be
> missing some context information. What is not clear to me about this patch
> is whether it changes a scsi_free_sgtable(cmd->prot_sdb, false) call into a
> scsi_free_sgtable(cmd->prot_sdb, true) call for the non-mq path ?

It does, and that is a bug.  Thanks for catching it!

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux