> -----Original Message----- > From: Hannes Reinecke [mailto:hare@xxxxxxx] > Sent: Thursday, 06 November, 2014 2:30 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@xxxxxxxxxxxxxxx; Hannes Reinecke > Subject: [PATCHv2 00/10] scsi logging update: the real thing > > Hi all, > > this is the second part of my scsi logging update, covering > CDB and sense code printing. With this patchset CDBs and > sense code bytes will be formatted on a single line > (where possible), and prefixed with the device and command > tag. > > To ensure CDBs and sense code bytes are not broken up during > printk I've implemented a per-cpu buffer for formatting > messages. One can allocate a chunk from the buffer using > scsi_log_reserve_buffer() and return it via > scsi_log_release_buffer(). > Both function do an implicit preempt_disable() / preempt_enable() > to ensure we're not scheduled away from that cpu whilst writing > into the buffer. > > With that I've been able to clean up constants.c to remove all the > #ifdef CONFIG_SCSI_CONSTANTS statements. It'll now be compiled in > conditionally if CONFIG_SCSI_CONSTANTS is set. > > Additionally I've updated the SCSI command definitions to SPC-3. > > Thanks go to Stephen Rostedt who suffered my annoying questions > during LPC. > I've run with v2 for a while. Tag prints look good; CDBs are coming out on one line, etc. I haven't tested every line of every patch, but I think I exercised patches 3, 5, 7, and 8 pretty thoroughly, so you may add this to those: Tested-by: Robert Elliott <elliott@xxxxxx> --- Rob Elliott HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
