One more comment on this one (which was PATCH 01 in v1 of the series, to which I sent most of my comments)... > -----Original Message----- > From: Hannes Reinecke [mailto:hare@xxxxxxx] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-scsi@xxxxxxxxxxxxxxx; Hannes Reinecke > Subject: [PATCH 03/10] scsi: Implement per-cpu logging buffer > > +++ b/drivers/scsi/scsi_logging.c > @@ -0,0 +1,119 @@ ... > +static DEFINE_PER_CPU(struct scsi_log_buf, scsi_format_log); > + > +static char *scsi_log_reserve_buffer(size_t *len) > +{ > + struct scsi_log_buf *buf; > + unsigned long map_bits = SCSI_LOG_SPOOLSIZE / SCSI_LOG_BUFSIZE; sizeof(buf->buffer) would be a bit safer than SCSI_LOG_SPOOLSIZE - adapts automatically if the real value used in the structure definition ever changes. --- Rob Elliott HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
