On 11/12/2014 12:13 PM, Kashyap Desai wrote: >> -----Original Message----- >> From: Tomas Henzl [mailto:thenzl@xxxxxxxxxx] >> Sent: Tuesday, November 11, 2014 7:14 PM >> To: Sumit.Saxena@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx >> Cc: martin.petersen@xxxxxxxxxx; hch@xxxxxxxxxxxxx; >> jbottomley@xxxxxxxxxxxxx; kashyap.desai@xxxxxxxxxxxxx; >> aradford@xxxxxxxxx >> Subject: Re: [PATCH 1/7] megaraid_sas : Driver version upgrade >> >> On 11/10/2014 01:21 PM, Sumit.Saxena@xxxxxxxxxxxxx wrote: >>> megaraid_sas driver version upgrade >>> >>> Signed-off-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxxx> >>> --- >>> drivers/scsi/megaraid/megaraid_sas.h | 2 +- >>> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/scsi/megaraid/megaraid_sas.h >> b/drivers/scsi/megaraid/megaraid_sas.h >>> index a49914d..f3eccf1 100644 >>> --- a/drivers/scsi/megaraid/megaraid_sas.h >>> +++ b/drivers/scsi/megaraid/megaraid_sas.h >>> @@ -33,7 +33,7 @@ >>> /* >>> * MegaRAID SAS Driver meta data >>> */ >>> -#define MEGASAS_VERSION "06.805.06.00- >> rc1" >>> +#define MEGASAS_VERSION "06.805.06.01- >> rc1" >>> #define MEGASAS_RELDATE "Sep. 4, 2014" >>> #define MEGASAS_EXT_VERSION "Thu. Sep. 4 > 17:00:00 >> PDT 2014" >> >> Usually you have changed the dates too, but this not important, feel > free to >> ignore it. > Agree that we always keep version/date sync-up in same patch. > I think having RELDATE is not really helpful and I see only megaraid_sas > driver use this. > > Probably we should keep only VERSION and remove RELDATE and EXT_VERSION EXT_VERSION is used to print a message to log - you can change it as you wish, I haven't noticed something similar to RELDATE in other drivers, so again I've no problem with any change. > >>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >> b/drivers/scsi/megaraid/megaraid_sas_base.c >>> index f6a69a3..36f463c 100644 >>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c >>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c >>> @@ -18,7 +18,7 @@ >>> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA > 02111-1307 >> USA >>> * >>> * FILE: megaraid_sas_base.c >>> - * Version : 06.805.06.00-rc1 >>> + * Version : 06.805.06.01-rc1 >>> * >>> * Authors: LSI Corporation >>> * Sreenivas Bagalkote > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
