On 11/11/2014 05:37 PM, Christoph Hellwig wrote: > On Thu, Nov 06, 2014 at 04:34:13PM +0100, Christoph Hellwig wrote: >> On Thu, Nov 06, 2014 at 09:21:05AM +0100, Hannes Reinecke wrote: >>> Hmm? Isn't there a scsi_put_comand() too many? >>> You dropped it from the 'if' branch, moved it out of >>> the condition, but kept in in the 'else' branch ... >> >> The put_device for the 'else' branch was hidden inside scsi_next_command. > > Is this a good enough explanation to get a Reviewed-by? > Yep. Reviewed-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html