Adding Vikas to verify if qla4xxx has the same issue. On 11/10/2014 12:52 AM, Minh Duc Tran wrote: > From: Minh Tran minhduc.tran@xxxxxxxxxx <mailto:minhduc.tran@xxxxxxxxxx> > > > > We are starting to see problems with certain open-iscsi > versions out there checking block valid bit. Iscsi boot target login > will not happen without this bit being set. > What versions of open-iscsi? Is it just the SUSE based versions? > > > Signed-off-by: Minh Tran <minhduc.tran@xxxxxxxxxx> > > --- > > scsi/be2iscsi/be_main.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/scsi/be2iscsi/be_main.c b/scsi/be2iscsi/be_main.c > > index 30d74a0..aacf223 100644 > > --- a/scsi/be2iscsi/be_main.c > > +++ b/scsi/be2iscsi/be_main.c > > @@ -429,7 +429,7 @@ static ssize_t beiscsi_show_boot_tgt_info(void > *data, int type, char *buf) > > auth_data.chap.intr_secret); > > break; > > case ISCSI_BOOT_TGT_FLAGS: > > - rc = sprintf(str, "2\n"); > > + rc = sprintf(str, "3\n"); > > break; > > case ISCSI_BOOT_TGT_NIC_ASSOC: > > rc = sprintf(str, "0\n"); > > @@ -466,7 +466,7 @@ static ssize_t beiscsi_show_boot_eth_info(void > *data, int type, char *buf) > > > > switch (type) { > > case ISCSI_BOOT_ETH_FLAGS: > > - rc = sprintf(str, "2\n"); > > + rc = sprintf(str, "3\n"); > > break; > > case ISCSI_BOOT_ETH_INDEX: > > rc = sprintf(str, "0\n"); > I think we want to move SYSFS_FLAG_FW_SEL_BOOT from ql4_def.h to include/linux/iscsi_boot_sysfs.h (also add a ISCSI_BOOT_ prefix), and then have both drivers use it. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html