> On 7.11.2014, at 1.54, Elliott, Robert (Server Storage) <Elliott@xxxxxx> wrote: > ... > 3. Reviewing the callers, st_release has an initialized > result variable but does nothing else with it but return it: > int result = 0; > ... > return result; > > It ignores the do_door_lock -> scsi_set_medium_removal > result (like many others). > The return code for automatic door locking/unlocking has been ignored on purpose. It is returned to caller for explicit door locking/unlocking. One can, of course, revise this decision. The return value of release() is ignored by VFS. The proper fix would probably be to define release() void. Thanks, Kai -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
