On Thu, Nov 06, 2014 at 05:28:32PM +0100, Bart Van Assche wrote:
> Apparently this patch removes the
> queue_flag_set_unlocked(QUEUE_FLAG_QUEUED, sdev->request_queue) call for
> the multiqueue case. I think it should be explained in the commit message
> why that has been done.
Ok, I will update it.
>> -static inline void scsi_deactivate_tcq(struct scsi_device *sdev, int depth)
>> -{
>> - if (blk_queue_tagged(sdev->request_queue))
>> - blk_queue_free_tags(sdev->request_queue);
>> - scsi_adjust_queue_depth(sdev, 0, depth);
>> -}
>
> Hmm ... where has the blk_queue_free_tags() call been moved to ?
It's gone. Despite the confusing name blk_queue_free_tags just clears
QUEUE_FLAG_QUEUED, which we now never do until the actual tag structure
is freed when the queue is torn via blk_release_queue ->
__blk_queue_free_tags.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
