>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxx> writes: Christoph> The calling conventions for this function where bad as it Christoph> could return -ENODEV both for a device not currently online Christoph> and a not recognized ioctl. s/where/were/ Christoph> Add a new scsi_ioctl_block_when_processing_errors function Christoph> that wraps scsi_block_when_processing_errors with the a Christoph> special case for the SG_SCSI_RESET ioctl command, and handle Christoph> the SG_SCSI_RESET case itself in scsi_ioctl. All callers of Christoph> scsi_ioctl now must call the above helper to check for the EH Christoph> state, so that the ioctl handler itself doesn't have to. Nice cleanup! Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
