On 11/04/2014 04:01 PM, Christoph Hellwig wrote: > On Tue, Nov 04, 2014 at 08:21:13AM +0100, Hannes Reinecke wrote: >> Why did you use a wrapper for an already existing function? >> Please fold the logic into alua_check_sense(). > > That's what the first version did. See the response from Rob to it > on why it's done this way. Hmm. I see. But I still thing it should be wrapped into alua_check_sense(). The main objection from Rob was that a sense code of 02/04/02 should cause a START STOP UNIT to be sent, but the latter is might be invalid for certain ALUA states. Thing is, we're only sending START STOP UNIT as part of the main SCSI EH routine, so that would work in either way. And looking a scsi_dh_alua we're only checking a return value of ADD_TO_MLQUEUE; any other value is treated as an I/O error. So it doesn't really matter if alua_check_sense would return FAILED here; it still would be folded into the final return value of SCSI_DH_IO. So I don't think we need to have a wrapper around alua_check_sense() but can rather merge them both. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
