>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxx> writes: Christoph> Allow a driver to ask for block layer tags by setting Christoph> .use_blk_tags in the host template, in which case it will Christoph> always see a valid value in request->tag, similar to the Christoph> behavior when using blk-mq. This means request-> even Christoph> SCSI "untagged" commands will now have a tag, which is Christoph> especially useful when using a host-wide tag map. Christoph> + scsi_adjust_queue_depth(dev, MSG_SIMPLE_TAG, cmd_per_lun); Christoph> + else Christoph> + scsi_adjust_queue_depth(dev, 0, cmd_per_lun); I kept tripping over these. In one case we have a well-defined MSG_SIMPLE_TAG constant in the other it's '0'. Also, when I read the disable case it's not immediately obvious whether the 0 is the queue depth or the tag type (although in the example above it's obvious due to it being cmd_per_lun). Anyway. Minor nitpicking. Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
