On 10/27/2014 06:26 AM, Finn Thain wrote: > The #defines in sun3_scsi.h are intended to influence subsequent #includes > in sun3_scsi.c. IMHO, that's too convoluted. > > Move sun3_scsi.h macro definitions to sun3_scsi.c, consistent with other > NCR5380 drivers. > > Omit the unused NCR5380_local_declare() and NCR5380_setup() macros. > > Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> Reviewed-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html