On Thu, Oct 23, 2014 at 10:28:52AM +0300, Dolev Raviv wrote: > Hi Dan, > This seem like a false alarm, please let me know if it requires a fix. > It may not indicate a bug, but it is correct in that the code could be re-written: Old: else if ((req_link_state == UIC_LINK_OFF_STATE) && (!check_for_bkops || (check_for_bkops && !hba->auto_bkops_enabled))) { Proposed: else if ((req_link_state == UIC_LINK_OFF_STATE) && (!check_for_bkops || !hba->auto_bkops_enabled)) { Those two are the same. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html