ping? On Wed, Oct 01, 2014 at 08:31:01PM +0200, Christoph Hellwig wrote: > As sparse correctly pointed out scsi_partsize should use get_unaligned_le32 > to read PC partition tables from disk, as they are little endian. > > The result of this bug is that we returned incorrect geometries on big > endian systems when using the scsicam variant. Which probably doesn't > matter as only old x86 systems every cared about the geometry. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > drivers/scsi/scsicam.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/scsicam.c b/drivers/scsi/scsicam.c > index 92d24d6..910f4a7 100644 > --- a/drivers/scsi/scsicam.c > +++ b/drivers/scsi/scsicam.c > @@ -163,8 +163,8 @@ int scsi_partsize(unsigned char *buf, unsigned long capacity, > end_head * end_sector + end_sector; > > /* This is the actual _sector_ number at the end */ > - logical_end = get_unaligned(&largest->start_sect) > - + get_unaligned(&largest->nr_sects); > + logical_end = get_unaligned_le32(&largest->start_sect) > + + get_unaligned_le32(&largest->nr_sects); > > /* This is for >1023 cylinders */ > ext_cyl = (logical_end - (end_head * end_sector + end_sector)) > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html ---end quoted text--- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
