Hi Subhash, 2014-10-06 7:38 GMT+09:00 Subhash Jadavani <subhashj@xxxxxxxxxxxxxx>: > Hi Akinobu, > > Thanks for the patch. After you reported the issue, I was looking through > our driver to make sure that why this issue was not catched and in fact it's > already have a fix internally and it was yet to be send upstream. > I am fine with your patch but our approach to fix the mentioned issue looks > more complete. > Here is what how we fixed it: > - After UFS link startup in ufshcd_probe(), link would anyway be in > PWM-G1, 1-lane, SLOW-AUTO mode so we would call a function namated > ufshcd_init_pwr_info() which would set the hba->pwr_info to reflect the > correct power mode after link startup. Here is the code reference: > https://www.codeaurora.org/cgit/quic/femto/kernel/msm-3.10/tree/drivers/scsi > /ufs/ufshcd.c?h=caf/msm-3.10#n4818. It would be good if you can adapt this > fix in your current patch. This looks more appropriate way to fix this problem. So I withdraw this patch. As this problem is not a regression, could you fix this in that way in your appropriate timing? Thanks for taking care of this. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
