> -----Original Message----- > From: Hannes Reinecke [mailto:hare@xxxxxxx] ... > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c ... > @@ -3328,9 +3319,19 @@ static void sd_print_sense_hdr(struct scsi_disk *sdkp, > sshdr->asc, sshdr->ascq); > } > > -static void sd_print_result(struct scsi_disk *sdkp, int result) > +static void sd_print_result(struct scsi_disk *sdkp, const char *msg, > + int result) > { > - sd_printk(KERN_INFO, sdkp, " "); > - scsi_show_result(result); > + const char *hb_string = scsi_hostbyte_string(result); > + const char *db_string = scsi_driverbyte_string(result); > + > + if (hb_string && db_string) > + sd_printk(KERN_INFO, sdkp, > + "%s: Result: hostbyte=%s driverbyte=%s\n", > + msg, hb_string, db_string); > + else > + sd_printk(KERN_INFO, sdkp, > + "%s: Result: hostbyte=0x%02x driverbyte=0x%02x\n", > + msg, host_byte(result), driver_byte(result)); In a similar construct, patch 19 used || in scsi_print_result to choose the string path, and printed "invalid" if one of the strings was NULL. They should probably match. --- Rob Elliott HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
