> -----Original Message----- > From: Hannes Reinecke [mailto:hare@xxxxxxx] ... > +struct sa_name_list { > + int cmd; > + const struct value_name_pair *arr; > + int arr_sz; > +}; cmd usually refers to a whole structure and is usually a pointer variable. grep searches will be easier if you name that field "opcode". > + > +static struct sa_name_list sa_names_arr[] = { > + {VARIABLE_LENGTH_CMD, variable_length_arr, VARIABLE_LENGTH_SZ}, > + {MAINTENANCE_IN, maint_in_arr, MAINT_IN_SZ}, > + {MAINTENANCE_OUT, maint_out_arr, MAINT_OUT_SZ}, > + {PERSISTENT_RESERVE_IN, pr_in_arr, PR_IN_SZ}, > + {PERSISTENT_RESERVE_OUT, pr_out_arr, PR_OUT_SZ}, > + {SERVICE_ACTION_IN_12, serv_in12_arr, SERV_IN12_SZ}, > + {SERVICE_ACTION_OUT_12, serv_out12_arr, SERV_OUT12_SZ}, > + {SERVICE_ACTION_BIDIRECTIONAL, serv_bidi_arr, SERV_BIDI_SZ}, > + {SERVICE_ACTION_IN_16, serv_in16_arr, SERV_IN16_SZ}, > + {SERVICE_ACTION_OUT_16, serv_out16_arr, SERV_OUT16_SZ}, > + {THIRD_PARTY_COPY_IN, tpc_in_arr, TPC_IN_SZ}, > + {THIRD_PARTY_COPY_OUT, tpc_out_arr, TPC_OUT_SZ}, > + {0, NULL, 0}, > +}; > + > +static bool scsi_opcode_sa_name(int cmd, int service_action, > + const char **sa_name) ... -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html